Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker file improvements #132

Open
miguelcleon opened this issue Apr 26, 2017 · 4 comments
Open

docker file improvements #132

miguelcleon opened this issue Apr 26, 2017 · 4 comments

Comments

@miguelcleon
Copy link
Member

@lsetiawan from issue #123
The next round of improvements are to allow user to

  1. use their own settings file
  2. use uwsgi to run as production
  3. separating the database from the application

I was thinking to use the model like docker-erddap, where user attach volume within their host machine to specify where the settings files are, and we have some sort of template where we can let user to download and use... What do you think @ocefpaf ?

@lsetiawan
Copy link
Member

@miguelcleon Alright, the lsetiawan/odm2admin docker image in docker hub has been updated.

@miguelcleon
Copy link
Member Author

@lsetiawan Yup, I tried it again from scratch, seems to work great! @emiliom installation through docker is now working 👍

@emiliom
Copy link
Member

emiliom commented Apr 27, 2017

👍 Awesome!

@miguelcleon miguelcleon mentioned this issue Jul 11, 2017
@lsetiawan
Copy link
Member

Going back to this improvement.

Here's what I have in mind.

  1. use their own settings file

Like docker-erddap, We host the core settings file somewhere users can download in a zip. They can then unzip the settings files, edit them however they like it to be. Take advantage of the -v to basically overwrite the settings in the Docker container, they can easily change the settings there.

I think we should default the base Database to SQLite maybe??

  1. use uwsgi to run as production

Technically, probably not need this one, but I think if the container gets shutdown and turned back on, runserver doesn't automatically execute.

  1. separating the database from the application

This is definitely necessary, since Docker containers should only have one application. So a sole ODM2-Admin django application container would be a good idea. I was thinking using Docker compose to connect each pieces? Need more research on this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants