Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Migration to version 12.0" wiki for reports #469

Open
dennybiasiolli opened this issue Sep 10, 2020 · 2 comments
Open

Update "Migration to version 12.0" wiki for reports #469

dennybiasiolli opened this issue Sep 10, 2020 · 2 comments

Comments

@dennybiasiolli
Copy link

In Odoo 12.0 the function for getting report values was renamed from get_report_values to _get_report_values.
It could be useful to specify this in the wiki section, task to do in the migration.

Something like:

  • Rename all def get_report_values functions to def _get_report_values inside AbstractModel for reports

Thanks!

@pedrobaeza
Copy link
Member

Well, that wiki tries to expose general changes, not as specific as this one, as there are tons of changes similar to this one depending on the area you are developing on, so the list can be very long. Anyway, I let others to judge if they consider that this should be added, being in the grey area.

cc @sbidoul @dreispt @simahawk

@dreispt
Copy link
Member

dreispt commented Sep 10, 2020

I see this useful, but it is quite topic specific.
What I think it could work well is have a first document focusing only on the framework-wide changes, and another one highlighting specific item per App/Module.
That second document would mention specific changes to take care for when migration Accounting, Project, etc.

AFAICT this particular change is not important for reports, in general, but for some advanced cases, and probably the report-focused repos. So I >could see a Reports section in this second document.

Just my 2 cents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants