From f6b940f1ea2379a5b087b6490426cc1c4f97ee53 Mon Sep 17 00:00:00 2001 From: Mathieu Benoit Date: Sun, 23 Jul 2023 01:31:05 -0400 Subject: [PATCH] [FIX] helpdesk_mgmt: format partner_email when receive it from new message from mail gateway Fill partner_name if partner_id not found --- helpdesk_mgmt/models/helpdesk_ticket.py | 7 ++++++- helpdesk_mgmt/tests/test_helpdesk_ticket.py | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/helpdesk_mgmt/models/helpdesk_ticket.py b/helpdesk_mgmt/models/helpdesk_ticket.py index f417a3d72a..ed1ba13e58 100644 --- a/helpdesk_mgmt/models/helpdesk_ticket.py +++ b/helpdesk_mgmt/models/helpdesk_ticket.py @@ -213,12 +213,17 @@ def message_new(self, msg, custom_values=None): """ if custom_values is None: custom_values = {} + partner_name, partner_email = next( + iter(tools.email_split_tuples(msg.get("from"))), ("", "") + ) defaults = { "name": msg.get("subject") or _("No Subject"), "description": msg.get("body"), - "partner_email": msg.get("from"), + "partner_email": partner_email, "partner_id": msg.get("author_id"), } + if not msg.get("author_id"): + defaults["partner_name"] = partner_name defaults.update(custom_values) # Write default values coming from msg diff --git a/helpdesk_mgmt/tests/test_helpdesk_ticket.py b/helpdesk_mgmt/tests/test_helpdesk_ticket.py index 2f1dc8f0c6..6729d698ff 100644 --- a/helpdesk_mgmt/tests/test_helpdesk_ticket.py +++ b/helpdesk_mgmt/tests/test_helpdesk_ticket.py @@ -75,6 +75,7 @@ def test_helpdesk_ticket_message_new(self): "message_id": msg_id, "subject": title, "email_from": "Bob ", + "from": "Bob ", "to": "jill@example.com", "cc": "sally@example.com", "recipients": "jill@example.com+sally@example.com",