fix: Improve Static Server Reliability #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuroDev
requested changes
Dec 23, 2024
| @@ -106,3 +127,44 @@ function handler( | |||
| }); | |||
| }; | |||
| } | |||
|
|
|||
| async function getStaticAssets(clientDir: string) { | |||
There was a problem hiding this comment.
Suggested change
| async function getStaticAssets(clientDir: string) { | |
| async function getStaticAssets(clientDir: string): Promise<Set<string>> { |
| return client; | ||
| } | ||
|
|
||
| function prependForwardSlash(pth: string) { |
There was a problem hiding this comment.
Suggested change
| function prependForwardSlash(pth: string) { | |
| function prependForwardSlash(pth: string): string { |
| return pth.startsWith('/') ? pth : '/' + pth; | ||
| } | ||
|
|
||
| function appendForwardSlash(pth: string) { |
There was a problem hiding this comment.
Suggested change
| function appendForwardSlash(pth: string) { | |
| function appendForwardSlash(pth: string): string { |
| * | ||
| * Copyright of withastro/adapters contributors, Reproduced under MIT License | ||
| */ | ||
| function resolveClientDir(options: InternalOptions) { |
There was a problem hiding this comment.
Suggested change
| function resolveClientDir(options: InternalOptions) { | |
| function resolveClientDir(options: InternalOptions): string { |
| const serverURLRaw = new URL(options.server); | ||
| const rel = path.relative(url.fileURLToPath(serverURLRaw), url.fileURLToPath(clientURLRaw)); | ||
|
|
||
| // walk up the parent folders until you find the one that is the root of the server entry folder. This is how we find the client folder relatively. |
There was a problem hiding this comment.
Suggested change
| // walk up the parent folders until you find the one that is the root of the server entry folder. This is how we find the client folder relatively. | |
| // Walk up the parent folders until you find the one that is the root of the server entry folder. This is how we find the client folder relatively. |
|
It also seems you have based this branch off of your branch used for #10 so the 2 you've put 2 PR's into 1. |
|
Marking as draft because it depends on types being corrected in #10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.webpimage inmdx#4