Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util.findUsers Should prioritise usernames over nicknames #1

Open
htmlcsjs opened this issue Dec 3, 2022 · 1 comment
Open

util.findUsers Should prioritise usernames over nicknames #1

htmlcsjs opened this issue Dec 3, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@htmlcsjs
Copy link

htmlcsjs commented Dec 3, 2022

Currently it is (probally) random, but it would be cool if it returned users with the username before nicknames.

here is it in action now:
image

@NotMyWing
Copy link
Member

I tried fiddling with it as much as I could, but couldn't find a solution that would be better than the current behavior.

Scoring usernames higher predictably results in the desired user being at the top.

Issue Flop: Issue Flop
Flow: Flow
Flow ®: Flow ®
floopa: floopa
homssu: homssu
Flooter: Flooter
SlopCity: SlopCity
PloppingFlopping: PloppingFlopping
jackalope: jackalope

However, this poses a problem. If custom nicknames are ranked lower, they have a chance to never appear in results at all despite being obviously closer to the query. Check how "Terra" is nowhere to be seen.

As an option, I'll try rolling out something else: sorting results without bias first, remember which value scored higher (user/display name), and then bubble user names up. This should hopefully be good.

@NotMyWing NotMyWing self-assigned this Dec 5, 2022
@NotMyWing NotMyWing added the bug Something isn't working label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants