Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public API changes #640

Closed
6 of 7 tasks
OmarTawfik opened this issue Nov 5, 2023 · 1 comment
Closed
6 of 7 tasks

public API changes #640

OmarTawfik opened this issue Nov 5, 2023 · 1 comment
Assignees

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Nov 5, 2023

as discussed in #617:

github-merge-queue bot pushed a commit that referenced this issue Jan 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2024
…rsing (#733)

Checks boxes in #640 #638

This adapts `ParserFunction` to always attempt parsing the leading
trivia after we had a succesful match. This has a nice side benefit of
not overwriting tokens that would allow for more progress when
collecting the final trivia (unlike previous [AttemptedParseRule,
EndOfFileTrivia] sequence).

I'm not so happy with the resulting tree shape, however; IMO we should
either:

1. return a "tree" that has both parents - the first one being the
expected parsed rule node but also the second parent being the "leading
trivia"
2. or at least introduce a notion of a virtual EndOfFile token that this
final end-of-file trivia can belong to.

Otherwise, a lone, final LeadingTrivia child belonging to the rule node
seems misplaced and it's not intuitive for me to find the remaining
trivia in that place. I'm open for other suggestions!
@OmarTawfik OmarTawfik assigned OmarTawfik and unassigned OmarTawfik Feb 10, 2024
@OmarTawfik OmarTawfik moved this to Todo in Slang - 2024 H1 Feb 13, 2024
@Xanewok
Copy link
Contributor

Xanewok commented Feb 19, 2024

I've opened #834 and #835 to track the remaining work items that we should probably still discuss, so closing this umbrella issue; the Area in the project board serves to show that these are related to the public API, so there's no use tracking them in a group here.

@Xanewok Xanewok closed this as completed Feb 19, 2024
@github-project-automation github-project-automation bot moved this from ⏳ Todo to ✅ Done in Slang - 2024 H1 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

No branches or pull requests

3 participants