Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Cursor in TypeScript #636

Closed
Xanewok opened this issue Nov 3, 2023 · 1 comment · Fixed by #676
Closed

Expose Cursor in TypeScript #636

Xanewok opened this issue Nov 3, 2023 · 1 comment · Fixed by #676
Assignees
@Xanewok

Comments

@Xanewok
Copy link
Contributor

Xanewok commented Nov 3, 2023

We do expose the Cursor already, but Visitor still needs to be exposed and ideally covered with a TS test.
@Xanewok Xanewok self-assigned this Nov 3, 2023
@OmarTawfik
Copy link
Contributor

Related PRs:

In addition, I see there are three remaining APIS with TODO comments in napi_cursor.rs.

@Xanewok Xanewok mentioned this issue Dec 2, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2023
@OmarTawfik
fix NAPI cursor types and expose cursor.depth (#676)
b496d36 
- expose `cursor.depth` API.
- add `cst.Node` union type.
- type check NAPI `index.d.ts`.
- replace `Cursor::find_*()` APIs with `go_to_*()` alternatives.

Fixes #636
@AntonyBlakey AntonyBlakey changed the title Expose Cursor and Visitor in TypeScript Expose Cursor in TypeScript Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
None yet
Projects
No open projects
Slang - 2023 Q4
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix NAPI cursor types and expose cursor.depth OmarTawfik-forks/slang
2 participants
@Xanewok @OmarTawfik