From 45607158b76dafc7282bb29e199ddc906873bd86 Mon Sep 17 00:00:00 2001 From: OmarTawfik <15987992+OmarTawfik@users.noreply.github.com> Date: Tue, 30 Jul 2024 07:39:04 -0700 Subject: [PATCH] test container privileged run --- .devcontainer/devcontainer.json | 1 + .github/workflows/benchmark.yml | 15 ++++----------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 80b8c4e9f2..cbf89db667 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -4,6 +4,7 @@ "build": { "dockerfile": "Dockerfile" }, + "privileged": true, "postAttachCommand": "/bin/bash scripts/bin/infra setup", "portsAttributes": { // _MKDOCS_WATCH_PORT_ | keep in sync with the port number defined in "$REPO_ROOT/crates/infra/cli/src/toolchains/mkdocs/mod.rs" diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 19006fc62b..dc50ad163e 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -27,16 +27,9 @@ jobs: - name: "Restore Cache" uses: "./.github/actions/cache/restore" - - name: "infra setup cargo" - uses: "./.devcontainer" - with: - entrypoint: "./scripts/bin/infra" - args: "setup cargo" - - name: "infra perf benchmark" - uses: "./.devcontainer" + uses: "devcontainers/ci@v0.3" with: - entrypoint: "./scripts/bin/infra" - args: "perf benchmark" - env: - BENCHER_API_TOKEN: "${{ secrets.BENCHER_API_TOKEN }}" + runCmd: "./scripts/bin/infra perf benchmark" + env: | + BENCHER_API_TOKEN=${{ secrets.BENCHER_API_TOKEN }}