binutils+patchelf: Upcoming incompatibility that already affects Fedora

[ADKaster]

Describe the bug

Patch bf6d7087de0a7351fd1dfd5f41522a7f4f576180 to binutils, applied to binutils 2.43.50, exposes a bad assumption in patchelf.

Binaries linked with this version of binutils crash when their rpath is modified with patchelf.

Steps To Reproduce

Steps to reproduce the behavior:

Ensure that the BFD linker has the referenced patch applied.

g++ -o hello hello.cpp
./hello
Hello, World!
patchelf --set-rpath '/usr/lib' ./hello # Any path fails
./hello
Segmentation fault (core dumped)

Expected behavior

Non-crashing binaries. The binutils maintainers have stated that they intend to keep this section re-order if possible, as it allows gdb to give more useful information when analyzing core dumps. (And there's not much activity on the patchelf bug tracker 😬 )

Screenshots

N/A

Additional context

https://bugzilla.redhat.com/show_bug.cgi?id=2319341
https://bugzilla.redhat.com/show_bug.cgi?id=2321588
NixOS/patchelf#568
microsoft/vcpkg#41576
LadybirdBrowser/ladybird#2149

Metadata

N/A

Notify maintainers

@Ericson2314 @lovesegfault

---

Note for maintainers: Please tag this issue in your PR.

---

Add a 👍 reaction to issues you find important.

[winterqt]

cc @Mic92

[Mic92]

We are currently stuck on an old patchelf version as well. I believe NixOS/patchelf#544 addresses most part of it. However the bigger issue with patchelf maintenance is that no matter how many regression test you add with every change you do, there is always something breaking in nixpkgs. I added issue to remove patchelf from stdenv, which would greatly help development: #362353 as it would remove the testing scope. All in all, not a very fun task to do, especially if you have to fix issues that only every happen in a nix build, and would require an stdenv rebuild to debug.