Feature Request: nflow explorer capable of querying all executor groups

[RealZimboGuy]

Hi,

Looking at the possibility of extending the nflow api, such that the executor group can be sent from explorer to be "all" or a specific executor group. the thought of this is that.

you can have two executor groups on the same database
ie nflow_one and nflow_two

from explorer you can select an executor group to view, at the moment you would need two nflow explorer instances connecting to the API for each executor group. but this could be useful to have one api/explorer to service both

the code in reference comes from the executor Dao in

    this.executorGroup = trimToNull(env.getRequiredProperty("nflow.executor.group")); 

to get this through would be an additional @RequestParam to the rest api in WorkflowInstanceResource.

then on nflow explorer, a new config to have a drop down list in the nav bar to select the executor group

[gmokki]

I think this is a very good and useful feature.
Maybe in addition to the above we also need an API to list the known executor groups.

[RealZimboGuy]

i was unsure of the api to "get executor groups" my initial thought was a config param in explorer (list of executor names). this was because you may want to have "hidden" executors. i may be over thinking it and a dynamic list from the api would probably be more practical

[RealZimboGuy]

@gmokki ive started on this feature,

• the default behaviour of the api remains as is, this means when no executor group is specified through the api it will only return the current api's executor groups results.
• a new system setting nflow.db.query_all_executors, this changes the default so that when no executor is specified it returns all.
  from this im looking at the nflow explorer side so that you can do all the normal controls across the different executors.

does the above sound about right ? or would it be better to change the default and not have a system setting for this ?

[RealZimboGuy]

current work in progress

[RealZimboGuy]

enhanced the create workflow to also have an executor selection

display the executor group under the details

enhance executors view to show all

some css changes to keep all search fields on the same line now with the extra field

@efonsell @gmokki
there is quite a few changes for all this, i have written some unit tests for the api specific things, whats the process to maybe check over my branch and review ?

[efonsell]

Sorry for taking so long to comment - the process is to create MR. There was some recent work on Explorer so you may have some conflicts in your branch, sorry about that as well.

In general, I think the screenshots look very good.

[RealZimboGuy]

@efonsell thanks, i have merged the new changes and made a PR for you to have a look

i noticed the new theme doesnt work well with dark mode, the nav item text is black on the already quite dark colour

#655