Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Function to find the largest element and its index #19

Open
seberg opened this issue Aug 22, 2024 · 0 comments
Open

ENH: Function to find the largest element and its index #19

seberg opened this issue Aug 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@seberg
Copy link
Collaborator

seberg commented Aug 22, 2024

Sometimes it is convenient to find the largest element and it's index at the same time. Of course finding the largest element can already be achieved with max().

The largest_element() function should return a tuple of value, index.

Working on this issue

This function already exists as a stub with some documentation. We have already provided a basic test as well.

  • Find and expand the largest_element stub with an implementation.
  • Find the test_largest_element test, and remove the @pytest.mark.xfail. Hopefully, the test passes now!
  • Commit your changes and create a PR.
@seberg seberg added the enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant