Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement a function to find the longest decreasing streak #18

Open
seberg opened this issue Aug 22, 2024 · 0 comments
Open

ENH: Implement a function to find the longest decreasing streak #18

seberg opened this issue Aug 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@seberg
Copy link
Collaborator

seberg commented Aug 22, 2024

We would like to have a small function that finds the longest streak of decreasing values.
For example given the list:

  • [3, 1, 2, 3, 2, 4] would find [1, 2, 3] at index 1.
  • [1, 2, 0, 10, 100] would find [0, 100, 100].

Working on this issue

Implementing bubblesort consists of the following things:

  • Find the existing longest_decreasing_streak stub and replace it with your implementation.
  • Add documentation (you can look at largest_lement or merge_sort for inspiration).
  • Add some tests by expanding the test_longest_decreasing_streak in test_inspect.py.
  • Once you have made your changes, and committed them to a new branch, you can create a PR!

(This is similar to gh-17, but we can work on two different implementations in parallel.)

@seberg seberg added the enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant