Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: replace_sublist function is missing tests #13

Open
seberg opened this issue Aug 20, 2024 · 0 comments
Open

TST: replace_sublist function is missing tests #13

seberg opened this issue Aug 20, 2024 · 0 comments
Labels
Tests Test improvements

Comments

@seberg
Copy link
Collaborator

seberg commented Aug 20, 2024

The replace_sublist function is implemented and documented. However, it is still missing tests.

We should add new tests to check basic replacements. This may also allow us to improve the implementation in the future.

Working on the issue

Familiarize yourself with the replace_sublist functionality. Then add some basic tests. There are already two stubs to add them:

  • test_replace_sublist_simple adding one or more examples.
  • test_replace_sublist_overlap, because it may be relevant to see what happens if a sublist like [1, 1] can have overlapping lists.

You can start implement only one of these of course. Once implemented confirm that the tests works with pytest ..
Then make sure you committed all your changes to a branch and open a pull request!

@seberg seberg added the Tests Test improvements label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Test improvements
Projects
None yet
Development

No branches or pull requests

1 participant