Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefiles not working #5

Open
mnieber opened this issue Mar 29, 2024 · 5 comments
Open

Makefiles not working #5

mnieber opened this issue Mar 29, 2024 · 5 comments

Comments

@mnieber
Copy link

mnieber commented Mar 29, 2024

Hi, I get various errors trying to run the makefiles. But cd-ing into the directory with the docker-compose file and then running docker-compose up works.

@derek-adair
Copy link

Yea, this doesn't work on wsl at all. I respect the hustle in this custom build pipeline and the meticulous organization but... why not just use compose and remove all the custom stuff?

@derek-adair
Copy link

Doesn't work on ubuntu either with /bin/bash, /bin/sh or /bin/zsh. Unsure what shell is being used here, but it'd be very nice for django-vite and this example repo to work out of the box for all users.

I was able to get this working by manually parsing the makefile and the related scripts. If anyone else would like to spin this up and test it out;

  1. Build each of the images in each of their respective directories;
    docker build -t django-vite:vite-app -f vite.Dockerfile . #in /docker/vite
    docker build -t django-vite:django-app -f django.Dockerfile . # in /docker/django
  2. Copy the env file from whatever version cp $SCRIPT_DIR/.env-example .env
  3. run source .env for your relevant demo
  4. docker compose up

@derek-adair
Copy link

If you are open to it I would be happy to submit a PR that simplifies building these demos in a way that will work for all users.

@Niicck
Copy link
Owner

Niicck commented Oct 4, 2024

If you are open to it I would be happy to submit a PR that simplifies building these demos in a way that will work for all users.

Totally, that'd be great. Sorry, I wasn't thinking about cross-platform compatibility when I was building this.

These commands could easily be migrated into a docker-compose file. And then maybe a python file to handle the .env creation instead of the Makefile command.

@derek-adair
Copy link

I have django vite working w/ docker compose on a project that I can migrate to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants