Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of other DBs #3

Open
nibynool opened this issue Sep 27, 2018 · 1 comment
Open

Support of other DBs #3

nibynool opened this issue Sep 27, 2018 · 1 comment

Comments

@nibynool
Copy link

From what I can tell (and please forgive me if I'm wrong), but this plugin looks as though it should support any DB that can be used with Sequelize, is that correct?

If it does would it be appropriate to remove the dependency on pg and allow users to select their preferred database?

@Nevon
Copy link
Owner

Nevon commented Oct 3, 2018

Yes, I believe that you are correct. I suspect that if you supply a connection string for a different DB, Sequelize will try to use whatever support module is necessary for that DB.

If so, we could move pg to be a peer dependency instead (because we want to make sure that people don't use pg >= 7, as it doesn't work with Sequelize currently). Feel free to give it a try and submit a PR if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants