Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file_create_date on write #990

Open
5 tasks done
rly opened this issue Jul 1, 2019 · 0 comments · May be fixed by #1163
Open
5 tasks done

Update file_create_date on write #990

rly opened this issue Jul 1, 2019 · 0 comments · May be fixed by #1163
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@rly
Copy link
Contributor

rly commented Jul 1, 2019

Feature Request

Opening an NWB file in any mode except 'r' should add an entry with the current date and time to NWBFile.file_create_date. It would be better if this could be changed only upon modification to the file, but with how h5py works, this does not appear to be trackable. (One could just do dataset[()] = some new data without calling io.write).

If this is not doable, I suggest 1) changing the documentation and 2) changing the variable type from array of datetimes to a single datetime.

Problem/Use Case

NWBFile.file_create_date is intended to store a record of the date and time an NWB file was created and all subsequent modifications made. But this is currently set to a list containing one element - the creation date. The list is never subsequently changed.

Checklist

  • Have you ensured the feature or change was not already reported ?
  • Have you included a brief and descriptive title?
  • Have you included a clear description of the problem you are trying to solve?
  • Have you included a minimal code snippet that reproduces the issue you are encountering?
  • Have you checked our Contributing document?
@rly rly added the category: enhancement improvements of code or code behavior label Jul 1, 2019
@t-b t-b linked a pull request Jan 29, 2020 that will close this issue
@t-b t-b self-assigned this Jan 29, 2020
@t-b t-b removed their assignment Jun 5, 2020
@stephprince stephprince added the priority: low alternative solution already working and/or relevant to only specific user(s) label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants