Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer docs for network tracking #24

Closed
oruebel opened this issue Feb 18, 2024 · 0 comments · Fixed by #35
Closed

Add developer docs for network tracking #24

oruebel opened this issue Feb 18, 2024 · 0 comments · Fixed by #35
Assignees

Comments

@oruebel
Copy link
Contributor

oruebel commented Feb 18, 2024

No description provided.

@oruebel oruebel self-assigned this Feb 18, 2024
oruebel added a commit that referenced this issue Mar 5, 2024
@oruebel oruebel mentioned this issue Mar 5, 2024
oruebel added a commit that referenced this issue Mar 5, 2024
Fix #24 

- Add documentation about the network tracking and how to use it in the
benchmarks
- Update the ``NetworkTracker`` class to track the total time directly,
rather than having the ``network_activity_tracker`` track the time
separately. This change addresses the following issues: a)
``NetworkTracker`` was missing the total time so results are not the
same compared to ``network_activity_tracker`` and 2)
``NetworkTracker.asv_network_statistics`` was not being updated in the
``network_activity_tracker`` so the timing result was not being
recorded.
- Update ``NetworkTracker`` and ``network_activity_tracker`` to allow
the user to optionally set the process ID to track. This will be useful
if/when we need to run code we want to profile in a separate process
(e.g., when running in node.js)

---------

Co-authored-by: Cody Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant