Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of example data depends on old WaveformExtractor #914

Open
bendichter opened this issue Aug 19, 2024 · 1 comment · May be fixed by #916 or #917
Open

Creation of example data depends on old WaveformExtractor #914

bendichter opened this issue Aug 19, 2024 · 1 comment · May be fixed by #916 or #917

Comments

@bendichter
Copy link
Collaborator

Describe the issue

Creation of example data depends on old WaveformExtractors

nwb-guide/src/pyflask/manageNeuroconv/manage_neuroconv.py

Lines 1725 to 1732 in 6356e1f

# Make Phy folder
waveform_extractor = spikeinterface.extract_waveforms(
recording=artificial_ap_band_in_uV, sorting=spiking, mode="memory"
)
export_to_phy(
waveform_extractor=waveform_extractor, output_folder=phy_output_folder, remove_if_exists=True, copy_binary=False
)

These lines are preventing us from upgrading to the latest version of SpikeInterface.

Steps to Reproduce

See above

Operating System

OSX

GUIDE Version

latest

Code of Conduct

Yes

Did you confirm this issue was not already reported?

Yes
@bendichter bendichter mentioned this issue Aug 19, 2024
Open
@bendichter
Copy link
Collaborator Author

@alejoe91 could you please help with this?

@bendichter bendichter assigned bendichter and unassigned bendichter Aug 21, 2024
@alejoe91 alejoe91 linked a pull request Aug 21, 2024 that will close this issue
Draft
@CodyCBakerPhD CodyCBakerPhD linked a pull request Aug 21, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bendichter