Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Override isempty for types.untyped.Set #561

Open
2 tasks done
ehennestad opened this issue Feb 6, 2024 · 0 comments · May be fixed by #616
Open
2 tasks done

[Feature]: Override isempty for types.untyped.Set #561

ehennestad opened this issue Feb 6, 2024 · 0 comments · May be fixed by #616
Labels
category: proposal discussion of proposed enhancements or new features status: todo something needs to be done topic: matnwb-api related to improving the matnwb api

Comments

@ehennestad
Copy link
Collaborator

ehennestad commented Feb 6, 2024

What would you like to see added to MatNWB?

At the moment an instance of types.untyped.Set can appear to be empty, but using the isempty function returns false.

Is your feature request related to a problem?

Example:

>> F = types.core.Fluorescence();
>> F.roiresponseseries

ans = 

  Empty Set

>> isempty(F.roiresponseseries)

ans =

  logical

   0

>> 

What solution would you like?

Override the isempty for types.untyped.Set

        % overloads isemty
        function tf = isempty(obj)
            tf = obj.Count == 0;
        end

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@ehennestad ehennestad added category: proposal discussion of proposed enhancements or new features status: todo something needs to be done topic: matnwb-api related to improving the matnwb api labels Oct 31, 2024
@ehennestad ehennestad linked a pull request Nov 4, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: proposal discussion of proposed enhancements or new features status: todo something needs to be done topic: matnwb-api related to improving the matnwb api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant