Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Only include namespaces for types that are included in NWB file on export #615

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Change: Only include namespaces for types that are included in NWB file on export #615

wants to merge 1 commit into from

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Nov 4, 2024 •
edited
Loading

Fix #607

Motivation

Ensure that only relevant namespaces/specifications are embedded in an NWB file. This issue suggests that such extra namespaces can cause errors when validating with NWBInspector.

How to test the behavior?

Export NWB file with types from a subset of available extension and check the file's `specification` group

Questions / todo

  • Are namespace names always specified in kebab-case?
  •  Does matnwb always format namespace names as snake_case?
  • Should the specification group be completely cleared before rewriting it if exporting to an existing file?

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (95b5e5e) to head (a458d62).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   90.90%   91.00%   +0.09%     
==========================================
  Files         107      107              
  Lines        4751     4768      +17     
==========================================
+ Hits         4319     4339      +20     
+ Misses        432      429       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Improve embedding of namespaces on nwbExport
1 participant
@ehennestad