Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Use new name=val pattern #570

Open
2 tasks done
bendichter opened this issue Jun 13, 2024 · 5 comments
Open
2 tasks done

[Feature]: Use new name=val pattern #570

bendichter opened this issue Jun 13, 2024 · 5 comments
Labels
category: enhancement improvements of code or code behavior status: todo something needs to be done topic: docs related to documentation

Comments

@bendichter
Copy link
Contributor

What would you like to see added to MatNWB?

MATLAB now allows you to have the syntax func(a=1, b=2), which is nicer and would be more similar to PyNWB. It would be nice to look at converting the library to use this syntax.

Is your feature request related to a problem?

No response

What solution would you like?

see above

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@lawrence-mbf
Copy link
Collaborator

Note that this syntax is only available in MATLAB R2021a which may impact users stuck or unwilling to upgrade to newer versions.

@bendichter
Copy link
Contributor Author

Yes, I have seen some applications where you can keep the old format as well, e.g. with plotting: https://www.mathworks.com/help/matlab/matlab_prog/namevalue-in-function-calls.html I'm not sure how we would implement this ourselves

@ehennestad
Copy link
Collaborator

It is already possible to use this syntax without changing anything in the library.

The question is, should tutorials be updated to use this newer syntax? And then the problem is, as @lawrence-mbf notes, that people using older versions would not be able to run the tutorials

@rly
Copy link
Contributor

rly commented Jul 13, 2024

PyNWB supports all currently alive/active versions of Python. Each version lasts five years. The documentation does not use features specific to only a subset of those versions.

I am in favor of updating the matnwb tutorials to use recently released MATLAB features that improve quality of life for the vast majority of users. Users running older versions can still use matnwb but would need to adjust the tutorial code. We could add a note about that in each tutorial, but this is pretty unfriendly to novices. I hope that this would impact relatively few users.

What should the time (or version) cutoff be? In my limited experience, when scientists start using a particular version of MATLAB for their data, they will not upgrade until the analysis is done, just in case the behavior of their code changes in later versions. Some people use older versions because their lab code doesn't run on newer versions. But they could also install a recent version of MATLAB to use matnwb without having to modify the tutorials. Three years sounds reasonable to me (which means I think we should update the tutorials to use the name=val pattern introduced in 2021a). Four or five years would be extra safe.

@rly
Copy link
Contributor

rly commented Jul 13, 2024

We could also just try it and roll it back if there are significant complaints.

@ehennestad ehennestad added category: enhancement improvements of code or code behavior topic: docs related to documentation status: todo something needs to be done labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior status: todo something needs to be done topic: docs related to documentation
Projects
None yet
Development

No branches or pull requests

4 participants