Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Tutorials following best practices specified by the NWBInspector #484

Open
2 tasks done
oruebel opened this issue Jan 6, 2023 · 1 comment
Open
2 tasks done
Labels
category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users status: todo something needs to be done topic: testing issues related to testing

Comments

@oruebel
Copy link
Contributor

oruebel commented Jan 6, 2023

What would you like changed or added to the documentation and why?

The following issue raised on PyNWB NeurodataWithoutBorders/pynwb#1628 I believe is also relevant for MatNWB.

Proposed Enhancement Enhance the test suite for the tutorials to run the NWBInspector on all files created by the tutorials to ensure that the files created by the tutorials follow best practices.

Do you have any interest in helping write or edit the documentation?

No.

Code of Conduct

@oruebel oruebel added category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users topic: docs related to documentation labels Jan 6, 2023
@ehennestad ehennestad added topic: testing issues related to testing status: todo something needs to be done and removed topic: docs related to documentation labels Oct 31, 2024
@ehennestad
Copy link
Collaborator

ehennestad commented Nov 2, 2024

@oruebel Would you suggest to use Importance level 0, 1 or 2 as a threshold for test failure?

class Importance(Enum):
    """A definition of the valid importance levels for a given check function."""

    ERROR = 4
    PYNWB_VALIDATION = 3
    CRITICAL = 2
    BEST_PRACTICE_VIOLATION = 1
    BEST_PRACTICE_SUGGESTION = 0

https://github.com/NeurodataWithoutBorders/nwbinspector/blob/c26924b89c8cbcd35a6e70ae04a5fc323d4bd92b/src/nwbinspector/_types.py#L8-L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: high impacts proper operation or use of feature important to most users status: todo something needs to be done topic: testing issues related to testing
Projects
None yet
Development

No branches or pull requests

2 participants