modification of namespace caching to exclude neurodata_types #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sent i.e., when caching extension
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 85.32% 85.32%
=======================================
Files 120 120
Lines 4335 4342 +7
=======================================
+ Hits 3699 3705 +6
- Misses 636 637 +1
Continue to review full report at Codecov.
|
|
this PR is unnecessary because the issue is with pynwb not saving 'data_types'. See issue #351 thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
Currently, matnwb caches neurodata_types in the namespace of NWB extensions. This differs from the behavior of pynwb, which leads to the file from failing validation.
This PR modifies +schemes/exportJson.m to exclude caching of 'neurodata_types' field from namespace. See issue #351 for further details.
With this modification matnwb-generated files with NWB extension in namespace pass verification:
$ python -m pynwb.validate ndx-ecog_file_test_matnwb.nwb Validating ndx-ecog_file_test_matnwb.nwb against cached namespace information using namespace 'ndx-ecog'. - no errors found.