Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation workflow to throw errors on invalid files #96

Open
stephprince opened this issue Sep 11, 2024 · 0 comments
Open

Fix validation workflow to throw errors on invalid files #96

stephprince opened this issue Sep 11, 2024 · 0 comments
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users

Comments

@stephprince
Copy link
Collaborator

The validate step in the test.yml workflow currently only print the nwbinspector report summary and will pass even if the inspector emits critical error warnings.

We should decide on a level of importance to use as a threshold and have the workflow fail when test files have issues.
@stephprince stephprince added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephprince