Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance direct unit tests for basic and private read functions #133

Closed
8 tasks done
oruebel opened this issue Jan 13, 2025 · 0 comments · Fixed by #139 or #142
Closed
8 tasks done

Enhance direct unit tests for basic and private read functions #133

oruebel opened this issue Jan 13, 2025 · 0 comments · Fixed by #139 or #142
Assignees
Labels
priority: low alternative solution already working and/or relevant to only specific user(s) topic: testing issues related to testing

Comments

@oruebel
Copy link
Contributor

oruebel commented Jan 13, 2025

This is a follow-up to #85

  • Add unit test for src/Utils.cpp , mergePaths() function (See Add unit tests for Utils.hpp #137 )
  • Add unit tests for new private HDF5IO internal functions. These may not require separate dedicated tested, but may be covered via the tests of the public core interfaces functions. However, we should check that they are indeed covered. NOTE: I checked with Cline and added another test in Add unit tests for BaseIO::findTypes #139
    • HDF5IO:: readDataHelper (note, there are two variants of this function)
    • HDF5IO::readStringDataHelper (note there are two variants of this function)
    • HDF5IO::getAttribute
  • Add unit test for BaseIO::findTypes (possibly as part of the HDF5IO tests) (See Add unit tests for BaseIO::findTypes #139)
  • Check unit test coverage for RegisteredType. This should be largely covered by the other tests, but we should check. (See Add unit tests for BaseIO::findTypes #139)
  • Check unit test coverage for ReadIO. This should be largely covered by the other tests, but we should check.
@oruebel oruebel added priority: low alternative solution already working and/or relevant to only specific user(s) topic: testing issues related to testing labels Jan 13, 2025
@oruebel oruebel mentioned this issue Jan 13, 2025
49 tasks
@oruebel oruebel closed this as completed Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low alternative solution already working and/or relevant to only specific user(s) topic: testing issues related to testing
Projects
None yet
1 participant