Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read columns via DynamicTable #130

Open
oruebel opened this issue Jan 13, 2025 · 1 comment · May be fixed by #143
Open

Read columns via DynamicTable #130

oruebel opened this issue Jan 13, 2025 · 1 comment · May be fixed by #143
Assignees
Labels
category: enhancement proposed enhancements or new features priority: medium non-critical problem and/or affecting only a small set of users

Comments

@oruebel
Copy link
Contributor

oruebel commented Jan 13, 2025

#85 adds core read capabilities. For DynamicTable specifically, it would be useful to have convenience methods to read VectorData columns that may also be specified dynamically and not be part of the schema.

This is also related to #131 , which may partially address this issue or at least provide functionality for implementing a solution to this issue.

Currently, a user can get the path from DynamicTable and the colNames to construct the paths or use findTypes to search for columns in the DynamicTable. However, DynamicTable itself does not provide a way to create ReadDataWrapper objects for the VectorData columns it manages.

@oruebel oruebel mentioned this issue Jan 13, 2025
49 tasks
@stephprince stephprince added category: enhancement proposed enhancements or new features priority: medium non-critical problem and/or affecting only a small set of users labels Jan 14, 2025
@oruebel
Copy link
Contributor Author

oruebel commented Jan 19, 2025

#142 adds the RegisteredType::readField method which supports reading of arbitrary subfields. To make this even more convenient we could add a DEFINE_CHILD_FIELD function to read fields that are itself instances of RegisteredType which would return the specific pointer type for the container (e.g., VectorData) instead of returning the generic RegisteredType pointer.

@oruebel oruebel linked a pull request Jan 19, 2025 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement proposed enhancements or new features priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants