Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move colNames from DynamicTable constructor to initialize #129

Open
oruebel opened this issue Jan 13, 2025 · 0 comments
Open

Move colNames from DynamicTable constructor to initialize #129

oruebel opened this issue Jan 13, 2025 · 0 comments
Assignees
@stephprince
Labels
category: enhancement proposed enhancements or new features priority: high impacts proper operation or use of a feature important to most users

Comments

@oruebel
Copy link
Contributor

oruebel commented Jan 13, 2025

To ensure DynamicTable can be created consistent with RegisteredClass interface, the colNames field should be removed from the constructor and instead be moved to the initialize function. See also related discussions in #85 here #85

This is also in part related to #107, which discusses handling of colNames in a more dynamic settings where columns are being added incrementally.
@oruebel oruebel added category: enhancement proposed enhancements or new features priority: medium non-critical problem and/or affecting only a small set of users labels Jan 13, 2025
@oruebel oruebel mentioned this issue Jan 13, 2025
Merged
49 tasks
@stephprince stephprince self-assigned this Jan 14, 2025
@stephprince stephprince added priority: high impacts proper operation or use of a feature important to most users and removed priority: medium non-critical problem and/or affecting only a small set of users labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephprince stephprince

Labels
category: enhancement proposed enhancements or new features priority: high impacts proper operation or use of a feature important to most users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oruebel @stephprince