We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different parts of the code assume path names with ending "/" and without ending "/". For example, DynamicTable assumes that it's path ends with "/"
DynamicTable
aqnwb/src/nwb/file/ElectrodeTable.hpp
Lines 89 to 90 in 5c37c40
aqnwb/src/nwb/hdmf/table/DynamicTable.cpp
Line 45 in 5c37c40
Line 58 in 5c37c40
Line 71 in 5c37c40
However, other Containers assume that path names do not have a "/" at the end, e.g., here:
Containers
aqnwb/src/nwb/base/TimeSeries.cpp
Line 51 in 5c37c40
In particular, all of these use the same variable "Container::path" that they inherit from "Container".
To avoid errors and ease use of the API, I propose to:
Container
ElectrodeTable
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Different parts of the code assume path names with ending "/" and without ending "/". For example,
DynamicTable
assumes that it's path ends with "/"aqnwb/src/nwb/file/ElectrodeTable.hpp
Lines 89 to 90 in 5c37c40
aqnwb/src/nwb/hdmf/table/DynamicTable.cpp
Line 45 in 5c37c40
aqnwb/src/nwb/hdmf/table/DynamicTable.cpp
Line 58 in 5c37c40
aqnwb/src/nwb/hdmf/table/DynamicTable.cpp
Line 71 in 5c37c40
However, other
Containers
assume that path names do not have a "/" at the end, e.g., here:aqnwb/src/nwb/base/TimeSeries.cpp
Line 51 in 5c37c40
In particular, all of these use the same variable "Container::path" that they inherit from "Container".
To avoid errors and ease use of the API, I propose to:
Container
remove trailing "/" from the pathDynamicTable
andElectrodeTable
to not assume trailing "/"The text was updated successfully, but these errors were encountered: