Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter support for RestPerf Collector #2534

Open
rahulguptajss opened this issue Dec 6, 2023 · 1 comment
Open

Add filter support for RestPerf Collector #2534

rahulguptajss opened this issue Dec 6, 2023 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@rahulguptajss
Copy link
Contributor

No description provided.

@rahulguptajss rahulguptajss added feature New feature or request status/open 24.02 labels Dec 6, 2023
@rahulguptajss rahulguptajss self-assigned this Dec 6, 2023
@rahulguptajss
Copy link
Contributor Author

rahulguptajss commented Dec 14, 2023

RestPerf Endpoint Filtering

Below are three methods for applying filters to RestPerf endpoints.

Use Case: filtering volumes by their names.

Approach 1: Cross-Field Query

Endpoint:

api/cluster/counter/tables/volume/rows?fields=*&query=test_vol&query_fields=properties.value

Limitations:

  1. Potential for false positives if other properties share the same value.

Approach 2: ID Regex Search

Endpoint:

api/cluster/counter/tables/volume/rows?fields=*&id=*test_vol*

Limitations:

  1. The ID for a volume is composed of the node, svm, volume, and uuid, formatted as node:svm:volume:uuid. This means the scope of this filtering is limited to the node, svm, and volume only.
  2. Similar to the first method, if any of the node, svm, or volume has a match with the regular expression, it may result in false positives.

Approach 3: Property Value Search

This method involves searching for a specific property value.

Endpoint:

api/cluster/counter/tables/volume/rows?fields=*&properties.value=osc_vol01

Limitations:

  1. Only properties with the specified value are returned in the response. Other properties are omitted from the results, although counters are available.
  2. As with the previous methods, this approach may also result in false positives.

Irrespective of the approach, code changes in collector will be same. Approach 1 and 2 looks good to me.

@rahulguptajss rahulguptajss changed the title Investigate filter support for RestPerf Collector Add filter support for RestPerf Collector Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant