From 9f35b44a799a90f4e45cf5d4183cffc16e361a47 Mon Sep 17 00:00:00 2001
From: Rahul Gupta <rahul.gupta@netapp.com>
Date: Wed, 9 Aug 2023 20:16:22 +0530
Subject: [PATCH] feat: address review comments

---
 conf/restperf/9.12.0/workload_detail.yaml            | 3 +++
 conf/restperf/9.12.0/workload_detail_volume.yaml     | 3 +++
 conf/zapiperf/cdot/9.8.0/workload_detail.yaml        | 3 +++
 conf/zapiperf/cdot/9.8.0/workload_detail_volume.yaml | 3 +++
 grafana/dashboards/cmode/workload.json               | 4 ++--
 5 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/conf/restperf/9.12.0/workload_detail.yaml b/conf/restperf/9.12.0/workload_detail.yaml
index 341206ff7..fad8fe340 100644
--- a/conf/restperf/9.12.0/workload_detail.yaml
+++ b/conf/restperf/9.12.0/workload_detail.yaml
@@ -7,6 +7,9 @@ object:                   qos_detail
 
 # recommended to use large interval, since workload objects are expensive
 client_timeout:           1m30s
+
+# Filter by workload class. Options: undefined, preset, user_defined, system_defined, autovolume, load_control
+# Note: autovolume is already gathered through workload_detail_volume.yaml
 workload_class:
   - user_defined
   - system_defined
diff --git a/conf/restperf/9.12.0/workload_detail_volume.yaml b/conf/restperf/9.12.0/workload_detail_volume.yaml
index 3550fcedb..30f6dfceb 100644
--- a/conf/restperf/9.12.0/workload_detail_volume.yaml
+++ b/conf/restperf/9.12.0/workload_detail_volume.yaml
@@ -6,6 +6,9 @@ object:                   qos_detail
 
 # recommended to use large interval, since workload objects are expensive
 client_timeout:           1m30s
+
+# Filter by workload class. Options: undefined, preset, user_defined, system_defined, autovolume, load_control
+# Note: user_defined,system_defined are already gathered through workload_detail.yaml
 workload_class:
   - autovolume
 
diff --git a/conf/zapiperf/cdot/9.8.0/workload_detail.yaml b/conf/zapiperf/cdot/9.8.0/workload_detail.yaml
index 634865527..443e740ab 100644
--- a/conf/zapiperf/cdot/9.8.0/workload_detail.yaml
+++ b/conf/zapiperf/cdot/9.8.0/workload_detail.yaml
@@ -9,6 +9,9 @@ instance_key:             name
 
 # recommended to use a large interval, since workload objects are expensive
 client_timeout:           1m30s
+
+# Filter by workload class. Options: undefined, preset, user_defined, system_defined, autovolume, load_control
+# Note: autovolume is already gathered through workload_detail_volume.yaml
 workload_class:
   - user_defined
   - system_defined
diff --git a/conf/zapiperf/cdot/9.8.0/workload_detail_volume.yaml b/conf/zapiperf/cdot/9.8.0/workload_detail_volume.yaml
index 3d98ef7ed..dc57e987e 100644
--- a/conf/zapiperf/cdot/9.8.0/workload_detail_volume.yaml
+++ b/conf/zapiperf/cdot/9.8.0/workload_detail_volume.yaml
@@ -8,6 +8,9 @@ instance_key:             name
 
 # recommended to use a large interval, since workload objects are expensive
 client_timeout:           1m30s
+
+# Filter by workload class. Options: undefined, preset, user_defined, system_defined, autovolume, load_control
+# Note: user_defined,system_defined are already gathered through workload_detail.yaml
 workload_class:
   - autovolume
 
diff --git a/grafana/dashboards/cmode/workload.json b/grafana/dashboards/cmode/workload.json
index 810929f88..f0e61672f 100644
--- a/grafana/dashboards/cmode/workload.json
+++ b/grafana/dashboards/cmode/workload.json
@@ -1607,7 +1607,7 @@
           "targets": [
             {
               "exemplar": false,
-              "expr": "topk($TopResources, qos_read_io_type{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",workload=~\"$TopQOSReadIOTypeFxmiss\", metric=\"fc_miss\"})",
+              "expr": "topk($TopResources, qos_read_io_type{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",workload=~\"$TopQOSReadIOTypeFcmiss\", metric=\"fc_miss\"})",
               "interval": "",
               "legendFormat": "{{workload}}",
               "refId": "A"
@@ -5962,7 +5962,7 @@
         "includeAll": true,
         "label": null,
         "multi": true,
-        "name": "TopQOSReadIOTypeFxmiss",
+        "name": "TopQOSReadIOTypeFcmiss",
         "options": [],
         "query": {
           "query": "query_result(topk($TopResources, avg_over_time(qos_read_io_type{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",workload=~\"$Workload\",metric=\"fc_miss\"}[${__range}])))",