Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of MMR function get_peak_index_and_height #132

Open
Sword-Smith opened this issue Jul 4, 2023 · 0 comments
Open

Change name of MMR function get_peak_index_and_height #132

Sword-Smith opened this issue Jul 4, 2023 · 0 comments

Comments

@Sword-Smith
Copy link
Member

This function returns the node index of a peak, not index into the MMR accumulator's peak list. Luckily it's a private function in twenty-first/src/util_types/mmr/mmr_membership_proof.rs, but it should still be changed, as we use the term "peak index" to refer to the index into the peaks list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant