Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 'stop' event threading #97

Open
NeonDaniel opened this issue Apr 3, 2023 · 0 comments
Open

[BUG] 'stop' event threading #97

NeonDaniel opened this issue Apr 3, 2023 · 0 comments
Assignees
@NeonDaniel
Labels
bug Something isn't working

Comments

@NeonDaniel
Copy link
Member

Description

If a user says 'stop' more than once, the handler is called multiple times, resulting in improper dialog in the second call (nothing to cancel).

Steps to Reproduce

With an expired alert, ask to 'stop' or send a 'stop' message more than once.

Relevant Code

https://github.com/NeonGeckoCom/skill-alerts/blob/dev/__init__.py#L1094

Other Notes

Consider a global or per-user lock around the 'stop' method
@NeonDaniel NeonDaniel added the bug Something isn't working label Apr 3, 2023
@NeonDaniel NeonDaniel self-assigned this Apr 3, 2023
@NeonDaniel NeonDaniel moved this to Other Helpful Tasks in Community Projects May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeonDaniel NeonDaniel

Labels
bug Something isn't working
Projects
Community Projects
Status: Other Helpful Tasks
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeonDaniel