-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: intent for "wake me" #145
base: dev
Are you sure you want to change the base?
Conversation
fc553f3
to
02543db
Compare
def test_wake_me_intent(self): | ||
from skill_alerts.util.parse_utils import build_alert_from_intent | ||
sea_tz = gettz("America/Los_Angeles") | ||
wake_me_up = _get_message_from_file("wake_me_up_at_time_alarm.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't missing in my local repo. Where are you seeing it missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NeonDaniel ping
Description
Adds support for "wake me" style intents for alarms.
Issues
Closes #119
Other Notes
I had some odd test results locally on my Macbook, hoping CI will be more forgiving