Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: intent for "wake me" #145

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat: intent for "wake me" #145

wants to merge 4 commits into from

Conversation

mikejgray
Copy link

Description

Adds support for "wake me" style intents for alarms.

Issues

Closes #119

Other Notes

I had some odd test results locally on my Macbook, hoping CI will be more forgiving

requirements.txt Show resolved Hide resolved
test/test_intents.yaml Show resolved Hide resolved
def test_wake_me_intent(self):
from skill_alerts.util.parse_utils import build_alert_from_intent
sea_tz = gettz("America/Los_Angeles")
wake_me_up = _get_message_from_file("wake_me_up_at_time_alarm.json")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't missing in my local repo. Where are you seeing it missing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Support "wake me up" to set an alarm
2 participants