Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Skills installed from config override existing versions #626

Open
mikejgray opened this issue Mar 3, 2024 · 2 comments
Open

[FEAT] Skills installed from config override existing versions #626

mikejgray opened this issue Mar 3, 2024 · 2 comments
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@mikejgray
Copy link
Contributor

Objective

When adding skills.default_skills or extra_dependencies.skills, they no longer seem to overwrite existing skills. It would be nice to have that behavior available, even if behind a config flag.

Initial Implementation Requirements

Make it so any skills added will override pre-installed skills

Other Considerations

No response

@mikejgray mikejgray changed the title [FEAT] [FEAT] Skills installed from config override existing versions Mar 3, 2024
@NeonDaniel
Copy link
Member

Was the skill possibly reporting the same version as what was already installed? When I do something like that manually, I pass --no-deps --force-reinstall, but that would break dependency installation under normal circumstances.. That could probably be appended to the specific entry though in config?

@mikejgray
Copy link
Contributor Author

mikejgray commented Mar 15, 2024

Was the skill possibly reporting the same version as what was already installed? When I do something like that manually, I pass --no-deps --force-reinstall, but that would break dependency installation under normal circumstances.. That could probably be appended to the specific entry though in config?

I was explicit in passing a different version, which I frequently do when testing new versions of the Home Assistant skill/plugin. It also wasn't a situation where the version hadn't changed yet - it was for different PyPi versions of published packages. If you'd like to make the --no-deps --force-reinstall path the official recommendation and add to docs, that's probably fine, but this functionality was available until recently. Not sure when it changed or which commit changed it.

@NeonDaniel NeonDaniel added feature New feature or request help wanted Extra attention is needed labels May 16, 2024
@NeonDaniel NeonDaniel moved this to Other Helpful Tasks in Community Projects May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Other Helpful Tasks
Development

No branches or pull requests

2 participants