-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ccall syntax to @ccall
#1932
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 97 97
Lines 35532 35533 +1
=======================================
+ Hits 31050 31051 +1
Misses 4482 4482 ☔ View full report in Codecov by Sentry. |
OK, but why? |
@fingolfin already wanted to do this for some time, but hadn't found the time to do it. |
ff3d4e8
to
2b74ef2
Compare
using a script
2b74ef2
to
f3f0ae1
Compare
@@ -1,2 +1,5 @@ | |||
# Adjusted indentation to 2 spaces | |||
ba3e1355fe8b2612b1f48d26ab68f6902efde691 | |||
|
|||
# Replaced many `ccall` by `@ccall` | |||
4850d2b8e7b3c6da47836a926f727bfabe4a6654 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I guess for that to work we'd need to "merge" (not rebase, not squash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
this PR was created by applying the following script to all relevant files.
I'll leave out some files to avoid conflicts with currently open PRs. To remember them for the future, the list of skipped files is:
src/calcium/ca.jl
,src/calcium/qqbar.jl
due to Add conversion QQBar -> Float64 #1893src/flint/fq_abs_series.jl
,src/flint/fq_rel_series.jl
due to Split series over fq_nmod and fq into different files #1929ping @fingolfin