Colvis cache #2700
Open
Colvis cache #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: build succeeded in my local environment when I built a 2.1.2 accumulo with my changes on top. There are breaking changes unrelated to my code that will need to be addressed before we can use 2.1.4 |
dtspence
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2699
Updates Attribute class to use Caffeine cache to store ColumnVisibility objects.
When the cache is used a copy of the original ColumnVisibility is made and returned to the caller.
This is made possible by the new copy constructor in Accumulo 2.1.4 so this PR is gated by that release.