Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Shows Multiple Markers for a Single BBL #1499

Open
dhochbaum-dcp opened this issue Mar 27, 2024 · 2 comments · May be fixed by #1504
Open

Map Shows Multiple Markers for a Single BBL #1499

dhochbaum-dcp opened this issue Mar 27, 2024 · 2 comments · May be fixed by #1504

Comments

@dhochbaum-dcp
Copy link
Collaborator

https://zap.planning.nyc.gov/projects?applied-filters=project_applicant_text&project_applicant_text=gompers
image
Note the two blue dots on the map. They represent the same project, which has the associated BBL 2025760026.

The boro and block are used in the geometry service to query the cartodb table 'dtm_block_centroids_v20201106'.

But if we look at the database in carto, we can see it is returning two centroids that match a boro=2 and block=2576.
image

While #1498 can be fixed without this issue being fixed, it is making it harder to troubleshoot #1498, and releasing a fix for #1498 without fixing this issue would undermine any confidence in its fuctionality.
@TylerMatteo
Copy link
Contributor

This might just be a limitation of using blocks for this functionality. Unrelated to this issue, I was going to suggest changing the code to use the dof_dtm_block_centroids table in Carto instead of the old dtm_block_centroids_v20201106. We should still do that but I confirmed that this issue still exists in that table. If block numbers simply aren't unique within a given borough, there's not much we can do here without rethinking how we geolocate projects.

@dhochbaum-dcp dhochbaum-dcp linked a pull request Apr 3, 2024 that will close this issue
Open
@dhochbaum-dcp
Copy link
Collaborator Author

I was able to fix this issue by creating a new table from dof_dtm_block_centroids which removes the duplicates, and have opened a PR which switches to use this new table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1499 Map Shows Multiple Markers for a Single BBL NYCPlanning/labs-zap-search
2 participants
@TylerMatteo @dhochbaum-dcp