Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managing agency filter to capital projects endpoints #400

Open
1 of 5 tasks
TylerMatteo opened this issue Jan 13, 2025 · 3 comments
Open
1 of 5 tasks

Add managing agency filter to capital projects endpoints #400

TylerMatteo opened this issue Jan 13, 2025 · 3 comments
Assignees

Comments

@TylerMatteo
Copy link
Collaborator

TylerMatteo commented Jan 13, 2025

Acceptance Criteria

  • All endpoints that return lists of capital projects have a new query parameter that allows the user to specify managing agency code to filter by
  • Only projects with commitments associated with the given agency should be returned
  • Add validation for new query parameter
  • New query parameter is reflected in OpenAPI spec (regenerate files as needed)
  • Add tests for new query parameter
@TangoYankee
Copy link
Member

Only projects with commitments associated with the given agency should be returned

Wait, is it only projects that are managed by the selected agency? Or is it projects where the commitments are sponsored by the selected agency? Project managing agencies and commitment sponsoring agencies are often different

@TangoYankee
Copy link
Member

Those endpoints being:

  • capital-projects (to get projects across all geographies)
  • boroughs/{boroughId}/community-districts/{communityDistrictId}/capital-projects (to get projects within the cd)
  • city-council-districts/{cityCouncilDistrictId}/capital-projects (to get projects in a ccd)

For the mvt endpoints, they already return the managing agency as a property. This allows the front end to filter the projects itself.

  • boroughs/{boroughId}/community-districts/{communityDistrictId}/capital-projects/{z}/{x}/{y}.pbf (to get project mvts within the cd)
  • capital-projects/{z}/{x}/{y}.pbf (to get project mvts across all geographies)
  • city-council-districts/{cityCouncilDistrictId}/capital-projects/{z}/{x}/{y}.pbf (to get projects in a ccd)

@pratishta
Copy link
Contributor

^ I'm assuming it's only projects that are managed by the selected agency since the filter in the designs explicitly label it as 'Managing Agency'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants