Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum and maximum commitments total filter to capital projects endpoint #399

Open
7 tasks
TylerMatteo opened this issue Jan 13, 2025 · 1 comment
Open
7 tasks

Comments

@TylerMatteo
Copy link
Collaborator

TylerMatteo commented Jan 13, 2025

Acceptance Criteria

  • capital-projects endpoint has two optional query parameters to filter projects based on the funding total
    • commitmentsTotalMin, for a minimum total of funding
    • commitmentsTotalMax, for a maximum total of funding
  • The parameters represent USD (with no multiplier like "Millions")
  • The query parameters may be used together or on their own
    • When only commitmentsTotalMin is used, all returned projects must have total funding above the minimum
    • When only commitmentsTotalMax is used, all returned projects must have total funding below the maximum
    • When both parameters are used together, all project must have total funding within the range
  • New query parameter is reflected in OpenAPI spec (regenerate files as needed)
  • Add unit and e2e tests for new query parameter

Validations

  • Return a 400 (invalid request parameter exception) if either provided value has more than two digits after the decimal place
  • Return a 400 (invalid request parameter exception) if both max and min are provided, but max is less than or equal to the min
@TangoYankee
Copy link
Member

How do we want to filter the mvts? Right now, the server doesn't return the total values as a property

@TylerMatteo TylerMatteo changed the title Add maximum project amount filter to capital projects endpoints Add minimum and maximum project amount filter to capital projects endpoint Jan 28, 2025
@TangoYankee TangoYankee changed the title Add minimum and maximum project amount filter to capital projects endpoint Add minimum and maximum commitments total filter to capital projects endpoint Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants