Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan's CommandList::copyTexture copies the entire region instead of slice. #41

Closed
01Pollux opened this issue Dec 18, 2023 · 1 comment
Closed

Vulkan's CommandList::copyTexture copies the entire region instead of slice. #41

01Pollux opened this issue Dec 18, 2023 · 1 comment

Comments

@01Pollux
Copy link

copyTexture(ITexture* _dst, const TextureSlice& dstSlice, IStagingTexture* _src, const TextureSlice& srcSlice) and copyTexture(IStagingTexture* _dst, const TextureSlice& dstSlice, ITexture* _src, const TextureSlice& srcSlice) uses vk::Extent3D srcMipSize/dstMipSize of the whole image instead of the slice that was resolved.

https://github.com/NVIDIAGameWorks/nvrhi/blob/99396539ea7f2e9c9858c1e737c81cbd96866b4d/src/vulkan/vulkan-staging-texture.cpp#L180-L182

https://github.com/NVIDIAGameWorks/nvrhi/blob/99396539ea7f2e9c9858c1e737c81cbd96866b4d/src/vulkan/vulkan-staging-texture.cpp#L229-L231

was this the intended behaviour?
apanteleev added a commit that referenced this issue Dec 19, 2023
@apanteleev
Fixed incorrect texture extents in copyTexture functions involving st…
3f62a4f 
…aging textures on Vulkan (#41)
@apanteleev
Copy link
Collaborator

This was a bug, now fixed. Thank you for reporting it!

GaelCathelin pushed a commit to GaelCathelin/nvrhi that referenced this issue Jan 11, 2024
@apanteleev @GaelCathelin
Fixed incorrect texture extents in copyTexture functions involving st…
b74bf82 
…aging textures on Vulkan (NVIDIA-RTX#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apanteleev @01Pollux