New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential buffer overflow issue in xml reader #1585

Open

fishautumn opened this issue Jan 21, 2025 · 0 comments

fishautumn commented Jan 21, 2025

nccl/src/graph/xml.cc

Line 57 in 1672c85

} while (c != '"');

  int o = 0;
  do {
    NCCLCHECK(xmlGetChar(file, &c));
    value[o++] = c;
  } while (c != '"');

node attribute has limited size of 256 bytes. It's better to check read length here to avoid unexpected error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment