Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swarm learning example #2064

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Update swarm learning example #2064

merged 5 commits into from
Nov 1, 2023
+156 −134

Conversation

SYangster
Copy link
Collaborator

  • Change swarm template to use .conf files with comments
  • Use script-dir option to get custom code rather than setting PYTHONPATH
  • Add section on runtime performance comparison

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the examples Label for all example related work label Oct 8, 2023
YuanTingHsieh
YuanTingHsieh reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, only one question

examples/advanced/swarm_learning/README.md Outdated Show resolved Hide resolved
@SYangster
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster merged commit 10f575e into NVIDIA:main Nov 1, 2023
holgerroth pushed a commit to holgerroth/NVFlare that referenced this pull request Dec 4, 2023
@SYangster
Update swarm learning example (NVIDIA#2064)
8121baa 
* Update swarm learning example

* Update swarm learning communication section with ad hoc
@SYangster SYangster deleted the swarm_benchmarks branch January 24, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

Assignees
No one assigned
Labels
examples Label for all example related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @YuanTingHsieh