Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2/_commonspeckle/Two_Time_Correlation_Function.py ToDos for V2 #59

Open
4 tasks
ambarb opened this issue Feb 9, 2021 · 1 comment
Open
4 tasks

v2/_commonspeckle/Two_Time_Correlation_Function.py ToDos for V2 #59

ambarb opened this issue Feb 9, 2021 · 1 comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Feb 9, 2021

Delete, move, and consolidate functions. We should do this in 3 steps:

Step 1

  • deletions for duplicates in place elsewhere if imported from elsewhere
  • deprecation error with raise and point to new function location if called or could be called when no import is required

Step 2

  • replace with imports if used in "sister module" to reduce code redundancy

Step 3

  • finalize consolidated module name and location
@ambarb
Copy link
Collaborator Author

ambarb commented Feb 9, 2021

Functions to delete

status function justification
run_time() Idefined in v2._futurepyCHX.chx_generic_functions and is built for more errors

@ambarb ambarb added _commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) V2 required to move towards share XPCS/speckle analysis for CHX/CSX labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

1 participant