Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] likely broken import of XPCS_XSVS_SAXS_Multi_2017_V4 - obsolete? can delete? #45

Open
ambarb opened this issue Oct 15, 2020 · 1 comment
Assignees
Labels
bug question V1 V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Oct 15, 2020

from pyCHX.chx_xpcs_xsvs_jupyter import run_xpcs_xsvs_single

Show it relies on a function from a package that does not exist. should import as

from pyCHX.chx_xpcs_xsvs_jupyter_V1 import run_xpcs_xsvs_single 

I did not discover in V1 (pyCHX), but found this to be the case in the default copies of V2 (pyCHX.v2._commonspeckle).

Is this module XPCS_XSVS_SAXS_Multi_2017_V4 still requiring use or can it be deleted because it is obsolete?
If still required, then we can discuss further

@ambarb ambarb added bug question V2 required to move towards share XPCS/speckle analysis for CHX/CSX V1 labels Oct 15, 2020
@ambarb
Copy link
Collaborator Author

ambarb commented Oct 22, 2020

@afluerasu believes this is obsolete but will check

@ambarb ambarb assigned ambarb and afluerasu and unassigned ambarb Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug question V1 V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

2 participants