Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] replacement for ModestImage dependancy #43

Open
1 of 2 tasks
ambarb opened this issue Oct 9, 2020 · 1 comment
Open
1 of 2 tasks

[v2] replacement for ModestImage dependancy #43

ambarb opened this issue Oct 9, 2020 · 1 comment
Labels
discussion help wanted question V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Oct 9, 2020

ModestImage was implemented as a dependency to better control matplotlib output. Unsure how much affects _common but this certainly affects _futurepyCHX

  • ModestImage is not part of standard analysis environment
  • Understand now that ModestImage is/was a young projects with single developer
  • Is ModestImage still being supported? Python 3.3 was the last PyPI release. https://pypi.org/project/ModestImage/

It seems functions imported from modest_image are:

  • from modest_image import imshow
  • from modest_image import ModestImage, imshow

In the following modules:

  • chx_compress_analysis.py
  • chx_generic_functions.py
  • chx_libs.py
  • Two_Time_Correlation_Function.py

It seems only that imshow is used.

  • I see no function calls that start with ModestImage in code base
  • what about in analysis pipeline? ModestImage is only imported in Two_Time_Correlation_Function; so check .ipynb for papermill.

So basically, it seems we need to understand how imshow from ModestImage improved plotting of 2D images.

@ambarb ambarb added discussion help wanted question V2 required to move towards share XPCS/speckle analysis for CHX/CSX labels Oct 9, 2020
@danielballan
Copy link
Contributor

@tacaswell Can you remind me what the motivation was for this and how we might get a similar result from plain mpl?

@ambarb ambarb assigned ambarb and unassigned ambarb Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion help wanted question V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

2 participants