Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AtomsBase unit tests fail due to cell comparison #17

Open
Alexsp32 opened this issue Oct 28, 2024 · 0 comments
Open

AtomsBase unit tests fail due to cell comparison #17

Alexsp32 opened this issue Oct 28, 2024 · 0 comments
Assignees
@Alexsp32
Labels
tests issues related to unit tests

Comments

@Alexsp32
Copy link
Member

Alexsp32 commented Oct 28, 2024 •
edited
Loading

Newest version of AtomsBase introduced breaking changes to AtomsBaseTesting.test_approx_eq, making our unit tests fail for identical Systems using different units. JuliaMolSim/AtomsBase.jl#128 submitted and waiting for clarification whether this behaviour is intended or not.
@Alexsp32 Alexsp32 self-assigned this Oct 28, 2024
@Alexsp32 Alexsp32 added the tests issues related to unit tests label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexsp32 Alexsp32

Labels
tests issues related to unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Alexsp32