FMS2_IO: correcting restart reads in remap_restarts #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art and not read_data
lharris4
approved these changes
Jan 2, 2025
| @@ -253,10 +253,6 @@ subroutine fv_restart(fv_domain, Atm, dt_atmos, seconds, days, cold_start, grid_ | |||
| !This call still appears to be necessary to get isd, etc. correct | |||
| !call switch_current_Atm(Atm(n)) !TODO should NOT be necessary now that we manually set isd, etc. | |||
|
|
|||
| !--- call fv_io_register_restart to register restart field to be written out in fv_io_write_restart | |||
There was a problem hiding this comment.
Much appreciated clean-up.
bensonr
reviewed
Jan 2, 2025
…ing of some remap restart fields in fv_io.
bensonr
approved these changes
Jan 10, 2025
|
@bensonr no I do not have a test case for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reading of restarts in the fv_io.F90
remap_restartssubroutine was mistakenly using read_data (fms2_io) rather than read_restart (fms2_io). This led to the issues seen in issue #204. This PR corrects this issue.Fixes #204
How Has This Been Tested?
Tested on Gaea with regression tests
Checklist:
Please check all whether they apply or not