Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make define_blocks warning a note #1570

Open
uramirez8707 opened this issue Aug 9, 2024 · 1 comment · May be fixed by #1588
Open

Make define_blocks warning a note #1570

uramirez8707 opened this issue Aug 9, 2024 · 1 comment · May be fixed by #1588

Comments

@uramirez8707
Copy link
Contributor

Describe the bug
Whenever you don't have even blocks, you will get this warning

"WARNING from PE     0: atmos_modeldefine_blocks: domain (  16  12) is not an even divisor with definition (   1   8) - blocks will not be uniform

Because this is warning, every PE outputs that warning, which causes the stdout to be very lengthy

To Reproduce
Use an uneven block size and you will get that warning

Expected behavior
This should be a NOTE, so that only the root pe outputs that warning

System Environment
This happens in any system

Additional context
N/A

@bensonr
Copy link
Contributor

bensonr commented Aug 9, 2024

For cases like the one you mention, everyone prints the warning and it isn't ideal. But there may be cases where you do a non-even domain layout divisor and only certain mpi-ranks will be uneven. For example, a c48 with a layout of 4,5 will give you 8 total domains of (12x9) and 12 total domains (12x10). Using block size of 1,5 will only print warnings for those 8 (12x9) domains where the block sizes won't be equal.

Let's modify the logic and message to output "N out of M total domains have non-uniform blocks for layout (p,q) and blocksize (r,s)"

@uramirez8707 uramirez8707 linked a pull request Sep 9, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants