Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow improvement #7

Open
aradhakrishnanGFDL opened this issue Jul 19, 2024 · 1 comment
Open

CI workflow improvement #7

aradhakrishnanGFDL opened this issue Jul 19, 2024 · 1 comment

Comments

@aradhakrishnanGFDL
Copy link
Collaborator

Proposing an enhanced test workflow with existing pytest suites.

Need job dependencies and sequences specified, such that conda package (or pip) is built before pytests are run.... or some version of this so that the pytests are always run on the current changes rather than the last stable release.

We also could have a dev and a stable conda release and use the former in the CI for a PR review.

@aradhakrishnanGFDL
Copy link
Collaborator Author

In addition to #8, we also need tests (pytests) that will be run with the conda package that is built as part of the workflow. @ilaflott points to fre-cli CI workflows which serve similar purposes and will be helpful to adapt them to fit the catalogbuilder land as well. So, we need meta.yaml changes to catalogbuilder such that pytests are run as part of build and publish. Specifically, using "commands" in meta.yml.

Reference https://github.com/NOAA-GFDL/fre-cli/blob/main/meta.yaml#L45-L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant