Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOCART AOD files not copied properly #2072

Open
CoryMartin-NOAA opened this issue Nov 16, 2023 · 3 comments · May be fixed by #2982
Open

GOCART AOD files not copied properly #2072

CoryMartin-NOAA opened this issue Nov 16, 2023 · 3 comments · May be fixed by #2982
Assignees
@WalterKolczynski-NOAA
Labels
bug Something isn't working

Comments

@CoryMartin-NOAA
Copy link
Contributor

What is wrong?

The GOCART instantaneous AOD is hard-coded to write out every 6 hours, but the copy routine at the end of the forecast job uses ${FV3_OUTPUT_FH} to loop through the forecast hours to copy these diagnostic files.

What should have happened?

These should be consistent. I know the AERO_HISTORY.rc file is not dynamic, so perhaps the simplest solution is to force the GOCART POSTDET routine to use 6 hour periods only, but Ideally the AERO_HISTORY file would be configurable.

What machines are impacted?

All or N/A

Steps to reproduce

Run the GDAS forecast in ATMA mode

Additional information

@andytangborn found the bug

Do you have a proposed solution?

No response
@CoryMartin-NOAA CoryMartin-NOAA added bug Something isn't working triage Issues that are triage labels Nov 16, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Nov 16, 2023
@WalterKolczynski-NOAA
Copy link
Contributor

Possibly related: #1629

@CoryMartin-NOAA
Copy link
Contributor Author

This issue will be a blocker for an aerosol 3DVar test. @aerorahul there is a quick fix (not sure it is the best one) to hard code forecast_postdet to match the hard code in the fix file. Longer term, the fix file would probably be best generated, but that is non-trivial due to the format. To be honest, it would surprise me if these gocart diagnostic files see the light of day in ops, when we would have UPP computing AOD for products, so perhaps it's best to do the hard code to every 6 hours?

@CoryMartin-NOAA
Copy link
Contributor Author

FYI @aerorahul this is still an issue that blocks adding an aerosol 3DVar test.

@CoryMartin-NOAA CoryMartin-NOAA mentioned this issue Feb 16, 2024
Closed
7 tasks
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Oct 4, 2024
@WalterKolczynski-NOAA
Make aerosol output frequency variable
237d3b3 
The `AERO_HISTORY.rc` file that controls the GOCART output is turned
into a template usint `@[ ]` syntax to allow for variable output
times. A new "parsing" script is created for GOCART that handles
parsing the `AERO_HISTORY.rc` file through `atparse`. Other manip-
ulation of these files is also moved to the new parsing script to be
consistent with other components.

A new variable, `FHOUT_AERO` is introduced to control the output
frequency of the GOCART output. This is initially set to 3 to match
other components (this is a change from the current value of 6).
Since some aerosol fields are also included as part of the atmos
output, it may be desirable to meld this back into `FHOUT` later.
However, the atmos output has two frequencies (`FHOUT_HF` and
`FHOUT`), a feature not supported by other components.

The RUN lists for aero fcst, aero analysis, and waves is simplified
to avoid confusion, since there is no need for them to only be set
if the components are on.

Resolves NOAA-EMC#2072
@WalterKolczynski-NOAA WalterKolczynski-NOAA linked a pull request Oct 4, 2024 that will close this issue
Open
12 tasks
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Oct 9, 2024
@WalterKolczynski-NOAA
Make aerosol output frequency variable
11f9a1d 
The `AERO_HISTORY.rc` file that controls the GOCART output is turned
into a template usint `@[ ]` syntax to allow for variable output
times. A new "parsing" script is created for GOCART that handles
parsing the `AERO_HISTORY.rc` file through `atparse`. Other manip-
ulation of these files is also moved to the new parsing script to be
consistent with other components.

A new variable, `FHOUT_AERO` is introduced to control the output
frequency of the GOCART output. This is initially set to 3 to match
other components (this is a change from the current value of 6).
Since some aerosol fields are also included as part of the atmos
output, it may be desirable to meld this back into `FHOUT` later.
However, the atmos output has two frequencies (`FHOUT_HF` and
`FHOUT`), a feature not supported by other components.

The RUN lists for aero fcst, aero analysis, and waves is simplified
to avoid confusion, since there is no need for them to only be set
if the components are on.

Resolves NOAA-EMC#2072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WalterKolczynski-NOAA WalterKolczynski-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@CoryMartin-NOAA @aerorahul @WalterKolczynski-NOAA